Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

➕ ament_cmake_gtest dependency #981

Merged
merged 4 commits into from
Jan 13, 2022
Merged

Conversation

tylerjw
Copy link
Member

@tylerjw tylerjw commented Jan 10, 2022

Description

I don't understand why the pre-release didn't catch this error. Thank you @jspricke for helping us find this.

Here is the build-farm error this should fix: https://build.ros2.org/job/Gbin_uF64__pilz_industrial_motion_planner__ubuntu_focal_amd64__binary/9/console

@henningkayser
Copy link
Member

I don't understand why the pre-release didn't catch this error. Thank you @jspricke for helping us find this.

The prerelease job is not installing dependencies for each package in an isolated environment, right?

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #981 (1adad55) into main (1faa2b1) will decrease coverage by 0.20%.
The diff coverage is 89.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #981      +/-   ##
==========================================
- Coverage   57.95%   57.75%   -0.19%     
==========================================
  Files         310      310              
  Lines       26132    26129       -3     
==========================================
- Hits        15141    15089      -52     
- Misses      10991    11040      +49     
Impacted Files Coverage Δ
.../include/moveit/robot_model/floating_joint_model.h 0.00% <ø> (ø)
...el/include/moveit/robot_model/planar_joint_model.h 33.34% <ø> (ø)
...include/moveit/robot_model/prismatic_joint_model.h 60.00% <ø> (ø)
.../include/moveit/robot_model/revolute_joint_model.h 100.00% <ø> (ø)
...bot_model/include/moveit/robot_model/robot_model.h 93.45% <ø> (ø)
moveit_core/robot_model/src/robot_model.cpp 74.79% <84.00%> (-0.03%) ⬇️
...bot_model/include/moveit/robot_model/joint_model.h 80.89% <100.00%> (-1.06%) ⬇️
...obot_model/include/moveit/robot_model/link_model.h 87.50% <100.00%> (-0.50%) ⬇️
moveit_core/robot_model/src/fixed_joint_model.cpp 33.34% <100.00%> (+2.57%) ⬆️
...veit_core/robot_model/src/floating_joint_model.cpp 48.97% <100.00%> (+0.27%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 800e37b...1adad55. Read the comment docs.

@henningkayser henningkayser added the backport-galactic Mergify label that triggers a PR backport to Galactic label Jan 13, 2022
@henningkayser henningkayser merged commit 86a24a4 into moveit:main Jan 13, 2022
mergify bot pushed a commit that referenced this pull request Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-galactic Mergify label that triggers a PR backport to Galactic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants