Skip to content
This repository has been archived by the owner on Nov 13, 2017. It is now read-only.

Deprecate moveit_metapackages repo #11

Closed
3 of 4 tasks
130s opened this issue Jan 5, 2017 · 6 comments
Closed
3 of 4 tasks

Deprecate moveit_metapackages repo #11

130s opened this issue Jan 5, 2017 · 6 comments

Comments

@130s
Copy link
Contributor

130s commented Jan 5, 2017

Why not deprecate this repo and move all existing metapackages to indigo-devel branch on moveit repo?

Moving metapackages into moveit repo can also prevent release maintainers from working on two different releases.

Steps to be made:

  1. Merge existing PR (currently only Add moveit_runtime metapkg #10)
  2. Import all the existing metapackages on this repo into the top level dir of moveit repo. --> I [Indigo] Move metapackages from moveit_metapackage repo. moveit#422, JK [Jade] Move a metapackage moveit_runtime from moveit_metapackage repo. moveit#436
  3. Deprecate notice for this repo (well actually deprecated notice is already posted at the top page of this repo).
  4. Open a new PR on rosdistro to move all the existing metapackages into the entry that is rooted on moveit repo. --> [Indigo][moveit] Add/update metapackages. ros/rosdistro#13767 --> NG. Need to bloom Deprecate moveit_metapackages repo #11 (comment)
@v4hn
Copy link

v4hn commented Jan 5, 2017

Sounds reasonable enough. +1 if it simplifies the release process.
I'm not yet convinced boiling down everything into one meta-package only is a wise decision.
At least it looks like we'll have another robot-specific package again in the future. ;)

@davetcoleman
Copy link
Member

+1 to more repo consolidation into moveit :)

@130s
Copy link
Contributor Author

130s commented Jan 11, 2017

I'm not yet convinced boiling down everything into one meta-package only is a wise decision.

I may have given you a wrong impression? My suggestion for meta packages and their location looks like the following:

moveit repo
|- moveit
|- moveit_full
|- moveit_full_pr2
|- (moveit_runtime once #10 merged)
|- (more if needed)
:
|- moveit_commander
|- (other non-meta packages)

@v4hn
Copy link

v4hn commented Jan 12, 2017

That's fine. Feel free to go ahead with this when you get around to do so..

@130s
Copy link
Contributor Author

130s commented Feb 6, 2017

As I left comment in the linked PR, I need to run bloom to complete moving the packages to another repo, which I'll work on shortly.

@130s 130s closed this as completed Feb 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants