Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing license/attribution? #11

Closed
gavanderhoorn opened this issue Aug 29, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@gavanderhoorn
Copy link
Member

commented Aug 29, 2016

The fanuc_description and fanuc_moveit_configuration packages added in #7 are copies of the respective M-10iA packages in ros-industrial/fanuc.

Those packages are licensed under the Apache v2 BSD 3-clause. If I'm not mistaken, that means that attribution / copyright notices must be retained and a copy of "the disclaimer" as well.

The stripped versions of the M-10iA packages don't seem to include that, so it would seem like that would need to be added in order to comply with the license.

@ksatyaki

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2016

It looks like the BSDv3 License.

@gavanderhoorn

This comment has been minimized.

Copy link
Member Author

commented Aug 29, 2016

Wait, right. You're correct (I was thinking of other ros-i pkgs). Doesn't change the issue though.

@ksatyaki

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2016

Yeah, true. I have committed it to my fork.

@gavanderhoorn

This comment has been minimized.

Copy link
Member Author

commented Aug 29, 2016

I think if this is addressed, it should be in a separate PR. Just so changes can be traced back to the issue(s) that necessitated them.

Also: the license should probably be placed in the fanuc* sub directories, not at the package root, as it doesn't cover the PR2 artefacts, fi.

@v4hn

This comment has been minimized.

Copy link
Member

commented Aug 29, 2016

+1 to @gavanderhoorn's ideas.

gavanderhoorn added a commit to gavanderhoorn/moveit_resources that referenced this issue Aug 30, 2016

gavanderhoorn added a commit to gavanderhoorn/moveit_resources that referenced this issue Nov 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.