Fixed typo in launch parameters #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no `<rename>` tag in roslaunch. There is `<remap>` though, which seems to be what the code is trying to do
|
completely true. |
130s
pushed a commit
that referenced
this pull request
Jun 22, 2017
There is no `<rename>` tag in roslaunch. There is `<remap>` though, which seems to be what the code is trying to do
|
Ported to |
davetcoleman
pushed a commit
to davetcoleman/moveit_tutorials
that referenced
this pull request
Oct 19, 2017
There is no `<rename>` tag in roslaunch. There is `<remap>` though, which seems to be what the code is trying to do
JonisK
added a commit
to JonisK/moveit_tutorials
that referenced
this pull request
Aug 6, 2018
… Some typos. In some places it does not make sense to replace the pr2 with the panda arm because the panda arm is fixed to the environment (see line moveit#57) and does not have a left and a right arm (see line moveit#81). I would suggest replacing panda with a mobile robot (e.g. the pr2) in line moveit#57 and using less specific termes like left_arm and right_arm in line moveit#81. Also, there were two typos that ocurred to me when reading the tutorial.
v4hn
pushed a commit
that referenced
this pull request
Aug 20, 2018
… Some typos. (#209) In some places it does not make sense to replace the pr2 with the panda arm because the panda arm is fixed to the environment (see line #57) and does not have a left and a right arm (see line #81). I would suggest replacing panda with a mobile robot (e.g. the pr2) in line #57 and using less specific termes like left_arm and right_arm in line #81. Also, there were two typos that ocurred to me when reading the tutorial.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no
<rename>tag in roslaunch. There is<remap>though, which seems to be what the code is trying to do