Fix #494: prevent zero-velocity commands during recovery behaviors #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…behaviors Partially reverts 0a686c9
|
I'm not sure why the CI failed -- I will look into it shortly |
|
mmm... change is terribly simple; cannot imagine how can make anything fail! I bet all tests will pass if run again; could you do so, @mikeferguson, assuming you are not on holidays? Many thanks! |
|
I think this might need to be ported to J/K as well? |
|
Seems like there's no problem on J/K. I didn't tried the code, but the line I removed on indigo is not there |
Combinacijus
pushed a commit
to Combinacijus/navigation
that referenced
this pull request
Mar 27, 2024
) * Update index.rst Fix typo * Update configuring-smac-2d.rst The previous format would cause errors in launching the nav2 package with SmacPlanner2D plugin with "parameter {GridBased.smoother.tolerance} is of type {double}, setting it to {string} is not allowed." * Update configuring-thetastar.rst The example snippet requires an extra indentation for the ros__parameters section. Otherwise, running the nav2 package would throw "rclcpp::exceptions::RCLInvalidROSArgsError" and complain "Couldn't parse params file".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially reverts 0a686c9