Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

min greater than max in AMCL.cfg #553

Closed
oscar-lima opened this issue Dec 29, 2016 · 1 comment
Closed

min greater than max in AMCL.cfg #553

oscar-lima opened this issue Dec 29, 2016 · 1 comment

Comments

@oscar-lima
Copy link

oscar-lima commented Dec 29, 2016

In lines 27, 28 of https://github.com/ros-planning/navigation/blob/kinetic-devel/amcl/cfg/AMCL.cfg

gen.add("beam_skip_distance", double_t, 0, "Distance from a valid map point before scan is considered invalid", 0, 2, 0.5)

gen.add("beam_skip_threshold", double_t, 0, "Ratio of samples for which the scans are valid to consider as valid scan", 0, 1, 0.3)

the order of dynamic reconfigure is: name, type, level, description, default, min, max

in this two cases min is greater than max, this disables reconfiguration, see image below

reconf

this is either a bug or a hack ! ?

@oscar-lima oscar-lima changed the title in AMCL.cfg min greater than max in AMCL.cfg Dec 29, 2016
@DLu DLu added the amcl label Apr 9, 2017
@mikeferguson
Copy link
Contributor

Definitely a bug -- this is a feature that was recently added and I believe is not frequently used. It's possible the author didn't spend much/any time using dynamic reconfigure with it.

mikeferguson added a commit that referenced this issue Apr 16, 2017
fix order of parameters (closes #553)
mikeferguson added a commit that referenced this issue Apr 16, 2017
fix order of parameters (closes #553)
mikeferguson added a commit that referenced this issue Apr 16, 2017
fix order of parameters (closes #553)
johaq pushed a commit to CentralLabFacilities/navigation that referenced this issue Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants