Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMCL node potential memory leak #729

Closed
davidNguyenHTD opened this issue May 23, 2018 · 1 comment
Closed

AMCL node potential memory leak #729

davidNguyenHTD opened this issue May 23, 2018 · 1 comment
Labels
amcl bug

Comments

@davidNguyenHTD
Copy link

In the function AmclNode::reconfigureCB of amcl_node.cpp, pf_ is allocated a new memory but pf_free( pf_ ) is not called before that. Should this potentially create memory leak each time the dynamic reconfigure callback is triggered?
@mikeferguson
Copy link
Contributor

Yup, that appears to be the case. PRs welcome.

mikeferguson added a commit that referenced this issue May 23, 2018
@mikeferguson
Merge pull request #730 from Glowcloud/melodic-devel
7f35563 
Fix for Potential Memory Leak  in AmclNode::reconfigureCB #729
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
amcl bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikeferguson @davidNguyenHTD