Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows][melodic] Navigation (except for map_server and amcl) Windows build bring up #851

Merged
merged 2 commits into from
Feb 13, 2020
Merged

[Windows][melodic] Navigation (except for map_server and amcl) Windows build bring up #851

merged 2 commits into from
Feb 13, 2020

Conversation

seanyen
Copy link
Contributor

@seanyen seanyen commented Jan 31, 2019

  • Add HAVE_SYS_TIME_H for conditionally disable the code for the system which doesn't have this header and related APIs. (The part to be conditionally disabled are all debug code, so I think it's fine to disable them for Windows build.)
  • Fix executable and shared lib install path for Windows.
  • attribute ((unused)) is GCC specific attribute, MSVC doesn't have it so let's conditionally define it.
  • Add #include to the header which uses std::min and std::max. Otherwise, MSVC will complain undefined functions.

@seanyen
Copy link
Contributor Author

seanyen commented Jan 31, 2019

I separate out map_server and AMCL changes here: (because it touches more code logic.)
#850 #849

@seanyen seanyen changed the title [Windows] Navigation (except for map_server and amcl) Windows build bring up [Windows][melodic] Navigation (except for map_server and amcl) Windows build bring up Feb 8, 2019
@seanyen seanyen mentioned this pull request Apr 1, 2019
Merged
@seanyen
Copy link
Contributor Author

seanyen commented May 5, 2019

@DLu @mikeferguson Hope I am pinging the correct owner. Let me know if anything I should iterate on. Thanks!

@seanyen
Copy link
Contributor Author

seanyen commented Jun 26, 2019

@DLu @mikeferguson Please excuse me to ping you again. Any chance I can move this PR forward? Thanks! Btw, this PR is also re-based to the latest. Hope that helps the review.

@mikeferguson mikeferguson reopened this Feb 13, 2020
@mikeferguson
Copy link
Contributor

Retriggering CI (didn't run for some reason)

@mikeferguson mikeferguson merged commit 347bdca into ros-planning:melodic-devel Feb 13, 2020
@seanyen seanyen mentioned this pull request Apr 11, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
costmap_2d melodic planners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seanyen @mikeferguson @DLu