Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing separator #5

Merged

Conversation

wjwwood
Copy link
Contributor

@wjwwood wjwwood commented Jun 13, 2018

Some of the .srv files are missing the --- if there is no response content, but ROS 2 requires that to be there.

See: ros2/rviz#267 (comment)

Connects to ros2/rviz#99

@wjwwood
Copy link
Contributor Author

wjwwood commented Jun 13, 2018

@mikaelarguedas I went ahead and made a pull request for this.

@mikaelarguedas
Copy link

👍

I dont have power in this organization (and should probably not approve my own PRs anyway) but the change looks good to me :)

@mikeferguson mikeferguson merged commit 0d9a0cf into ros-planning:ros2 Jun 14, 2018
@mikeferguson
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants