Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MoveIt! clang format for SRDF #42

Merged
merged 1 commit into from
Oct 25, 2018

Conversation

davetcoleman
Copy link
Member

@jonbinney
Copy link
Contributor

Looks good - I'm building this just to sanity check.

Copy link
Contributor

@jonbinney jonbinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonbinney jonbinney merged commit 6a9c757 into moveit:melodic-devel Oct 25, 2018
@rhaschke
Copy link
Contributor

@jonbinney Please be more careful before merging. This PR was failing on Travis!

@jonbinney
Copy link
Contributor

@rhaschke my mistake - will be more careful in the future.

To clarify, this didn't fail any of the existing checks. It added a new check that fails right now on melodic, since clang-format-3.8 package doesn't exist on 18.04. That should be fixed once moveit/moveit_ci#39 is debugged and merged.

@davetcoleman davetcoleman deleted the melodic-clang branch October 27, 2018 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants