-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added initial version of gazebo_ros2_control #1
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reviving this.
Are you planning to add a CI as well?
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tried it out, but I just left some general comments about style, linting, etc.
gazebo_ros2_control/include/gazebo_ros2_control/default_robot_hw_sim.h
Outdated
Show resolved
Hide resolved
gazebo_ros2_control/include/gazebo_ros2_control/default_robot_hw_sim.h
Outdated
Show resolved
Hide resolved
gazebo_ros2_control/include/gazebo_ros2_control/default_robot_hw_sim.h
Outdated
Show resolved
Hide resolved
gazebo_ros2_control/include/gazebo_ros2_control/gazebo_ros2_control_plugin.h
Outdated
Show resolved
Hide resolved
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing all my nitpicks! I just took another high-level look and it looks like a great start!
Great! thank you for the reviews! |
Based on the effort done by @ddengster in this PR ros-simulation/gazebo_ros_pkgs#1083 porting
gazebo_ros_control
to ROS 2. I have been working in reproduce the results. I tried "fix" some of the issue that I found in the code and comments@chapulina @Karsten1987
I know this is not a final solution. It's just make it work in ROS 2.
Signed-off-by: ahcorde ahcorde@gmail.com