[noetic] Adapted to OpenCV4 #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
Closed
chapulina
approved these changes
Mar 31, 2020
|
Could this be backported to melodic? The new header style has been introduced in OpenCV2.4.11, so that would introduce no problems for melodic (target cv version is 3.2+, see REP 3) but makes it possible to use melodic with cv4. |
|
@timonegk , sure, please feel free to open a pull request against melodic and we can merge it if CI passes. Thanks! |
|
Okay, I opened a PR, thank you! |
seanyen
pushed a commit
to ms-iot/gazebo_ros_pkgs
that referenced
this pull request
Aug 31, 2020
Signed-off-by: ahcorde <ahcorde@gmail.com>
nim65s
added a commit
to nim65s/robotpkg-wip
that referenced
this pull request
Sep 27, 2021
This shouldn't break build for 18.04 / melodic / opencv3, ref: ros-simulation/gazebo_ros_pkgs#1068 (comment)
cohen39
pushed a commit
to cohen39/gazebo_ros_pkgs
that referenced
this pull request
Nov 15, 2021
Signed-off-by: ahcorde <ahcorde@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified headers for OpenCV4
Signed-off-by: ahcorde ahcorde@gmail.com