Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include preprocessor conditions to avoid compile OnNewNormalsFrame and OnNewReflectanceFrame #1071

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Mar 31, 2020

OnNewReflectanceFrame and OnNewNormalsFrame will be introduce exclusively in Gazebo 9 for minor version > 12.

These preprocessor conditions allow to compile for other Gazebo versions

Signed-off-by: ahcorde ahcorde@gmail.com

…d OnNewReflectanceFrame

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde mentioned this pull request Mar 31, 2020
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once this is ported forward to Gazebo 10 and 11 we'll need to add their versions here too. Especially 11, since that's going to be the official version on Noetic.

@chapulina chapulina merged commit 8e53be6 into ros-simulation:noetic-devel Mar 31, 2020
cohen39 pushed a commit to cohen39/gazebo_ros_pkgs that referenced this pull request Nov 15, 2021
…d OnNewReflectanceFrame (ros-simulation#1071)

Signed-off-by: ahcorde <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants