Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Noetic] Delete request msgs #1160

Merged
merged 1 commit into from
Sep 8, 2020
Merged

[Noetic] Delete request msgs #1160

merged 1 commit into from
Sep 8, 2020

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 8, 2020

Delete request msgs to fix memory leak as done in pull request #1097

@iche033
delete request msgs
467e939 
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
chapulina
chapulina approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing test is flaky: http://build.ros.org/job/Npr__gazebo_ros_pkgs__ubuntu_focal_amd64/31/testReport/junit/__main__/TestRangePlugin/test_inside_range/history/

@chapulina chapulina merged commit 2604da1 into noetic-devel Sep 8, 2020
@chapulina chapulina deleted the delete_req_noetic branch September 8, 2020 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iche033 @chapulina