Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End of legacy for diff drive plugin #707

Merged
merged 1 commit into from
May 29, 2018

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero commented Apr 9, 2018

In old versions of the code the right and left wheel were changed to fix a former code issue. To fix an old package you have to exchange left wheel by the right wheel. This PR ends with the option to set legacy in a ROS parameter.

In old versions of the code the right and left wheel were changed
to fix a former code issue. To fix an old package you have to
exchange left wheel by the right wheel.

This PR ends with the option to set legacy in a ROS parameter.
@j-rivero
Copy link
Contributor Author

j-rivero commented Apr 9, 2018

@osrf-jenkins run tests please

Copy link
Collaborator

@kev-the-dev kev-the-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removes all trace of this from repo and appears correct to me.

@j-rivero
Copy link
Contributor Author

@osrf-jenkins run tests please

@j-rivero j-rivero mentioned this pull request May 25, 2018
5 tasks
@j-rivero j-rivero merged commit 2eb6dcb into melodic-devel May 29, 2018
@scpeters scpeters deleted the end_of_diffdrive_legacy_melodic branch May 29, 2018 20:03
cohen39 pushed a commit to cohen39/gazebo_ros_pkgs that referenced this pull request Nov 15, 2021
In old versions of the code the right and left wheel were changed
to fix a former code issue. To fix an old package you have to
exchange left wheel by the right wheel.

This PR ends with the option to set legacy in a ROS parameter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants