[Windows][melodic] Basic gazebo scripts to support launch file on Windows build. #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanyen
changed the title
|
@chapulina Hope I am pinging the correct owner. It would be great I can get some feedback and move this PR forward (and #878 #879). Thanks! |
|
@seanyen , I've been focusing on the ROS 2 side of things but I can help out with ROS 1 when I have spare cycles. In any case, since this PR only touches Windows, and you're the Windows expert who has done most of the heavy lifting to get Gazebo working on Windows, I'm happy to get it in. |
nim65s
pushed a commit
to nim65s/robotpkg
that referenced
this pull request
Mar 9, 2020
patch-ab: adapt patch-ad: python 3 compatibility Changelog for package gazebo_ros ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 2.8.6 (2019-12-26) ------------------ * ROS API: remove unhelpful error in GetWorldProperties call (`%747 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/747>`_) * Create reconfigure thread only if network enabled (`%919 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/919>`_) This thread was blocked in client.waitForExistance because the services it depends on are only created if `enable_ros_network` is true. This in turn blocked gazebo from being shut down. Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * spawn_model: Fix urlparse imports for Python 3 * spawn_model: Ensure that "model_xml" is a string, required for Python 3 * catkin_find gazebo plugin from bin folder. (`%993 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/993>`_) * [Windows][melodic-devel] more Windows build break fix (`%975 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/975>`_) * Fix CMake install error for Windows build. * conditionally include <sys/time.h> * provide Windows implemenation for setenv. (`%879 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/879>`_) * implement basic gazebo scripts to support launch file on Windows build. (`%880 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/880>`_) * Contributors: Kartik Mohta, Kevin Allen, Sean Yen, Shane Loretz 2.8.5 (2019-06-04) ------------------ * Add output arg to launch files, plus some small fixes (melodic) (`%907 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/907>`_) * Add output arg to empty_world * add output arg to elevator_world * add output arg to range_world * don't set use_sim_time in range_world Instead parse it to empty world, where it will be set. * add xml prolog to all launch files * Remove unnecessary arg in range_world.launch * use C++11 std sleep instead of usleep. (`%877 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/877>`_) * fix issue `%198 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/198>`_ (`%825 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/825>`_) * Lower minimum cmake version (`%817 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/817>`_) * Contributors: Matthijs van der Burgh, Paul Bovbel, Sean Yen [MSFT], Steven Peters Changelog for package gazebo_ros_control ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 2.8.6 (2019-12-26) ------------------ * restrict Windows header namespace. (`%1023 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/1023>`_) * [Windows][melodic-devel] more Windows build break fix (`%975 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/975>`_) * Fix CMake install error for Windows build. * conditionally include <sys/time.h> * Contributors: Sean Yen 2.8.5 (2019-06-04) ------------------ * use C++11 std sleep instead of usleep. (`%877 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/877>`_) * Lower minimum cmake version (`%817 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/817>`_) * Contributors: Paul Bovbel, Sean Yen [MSFT] Changelog for package gazebo_plugins ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 2.8.6 (2019-12-26) ------------------ * gazebo_plugins: export plugin path in package.xml (`%923 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/923>`_) * Fix destructor of gazebo_ros_diff_drive.cpp (`%1021 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/1021>`_) Fix issue referenced in `%123 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/123>`_ where the destructor of ROS DiffDrive plugin causes gzserver to crash on model deletion. * [Windows][melodic-devel] more Windows build break fix (`%975 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/975>`_) * Fix CMake install error for Windows build. * conditionally include <sys/time.h> * Use ignition::math::Rand utility for portability. (`%878 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/878>`_) * Contributors: Ben Wolsieffer, RemiRigal, Sean Yen 2.8.5 (2019-06-04) ------------------ * use C++11 std sleep instead of usleep. (`%877 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/877>`_) * Lower minimum cmake version (`%817 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/817>`_) * Contributors: Paul Bovbel, Sean Yen [MSFT]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to add basic gazebo scripts (gzclient.bat, gzserver.bat, debug.bat) to support Gazebo ROS launch file. The Gazebo side change is required https://bitbucket.org/osrf/gazebo/pull-requests/3070/gazebo9-add-setupbatin-for-windows-build/diff
This change is verified on https://aka.ms/ros project.