Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a problem twice named with ros namespace. #920

Merged
merged 1 commit into from Jan 8, 2020
Merged

Fix a problem twice named with ros namespace. #920

merged 1 commit into from Jan 8, 2020

Conversation

shun818
Copy link
Contributor

@shun818 shun818 commented Apr 23, 2019

Occured problem:

I insert gazebo_ros_imu_sensor plugin my robot.

<plugin filename="libgazebo_ros_imu_sensor.so" name="imu_plugin">
  <robotNamespace>robotNamespace</robotNamespace>
  <topicName>imu</topicName>
  ...
</plugin>

and launch file is

<node pkg="gazebo_ros" type="spawn_model" name="spawn_robot" args="
  -urdf
  ...
  -robot_namespace robotNamespace
</node>

then, gazebo was published ROS topic is named /robotNamespace/robotNamespace/imu

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks correct to me, but we shouldn't merge this into melodic because it would break existing users. Would you mind targeting this PR at noetic-devel?

It would also be nice to add a more verbose commit message about this, which will go into the changelog, so users migrating from melodic to noetic can quickly find out how to migrate their code.

Thanks!

@shun818
Copy link
Contributor Author

shun818 commented Jan 8, 2020

No problem. However, I am not familiar with the operation of Github. Can you change this PR target?

@chapulina chapulina changed the base branch from melodic-devel to noetic-devel January 8, 2020 18:00
@chapulina chapulina merged commit bd605b1 into ros-simulation:noetic-devel Jan 8, 2020
cohen39 pushed a commit to cohen39/gazebo_ros_pkgs that referenced this pull request Nov 15, 2021
gazebo_ros_imu_sensor: robotNamespace is no longer duplicate inside topics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants