Backport #1202 to kinetic: fix performance metrics #1209
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #1202 to
kinetic-devel
, an alternative to #1180:We are currently subscribing to the
/gazebo/performance_metrics
topic even if there are no subscribers to the ROS topic forwarding this data. Thelink_states
andmodel_states
topics currently use an advertise mechanism with callbacks when a subscriber connects or disconnects, so I've used that same pattern for theperformance_metrics
topic.This also helps workaround the deadlock documented in #1175 and gazebosim/gazebo-classic#2902.
I've also added the
GAZEBO_ROS_HAS_PERFORMANCE_METRICS
macro to de-duplicate the gazebo version checking logic and made some minor doc-string and spelling fixes.