PublishSimTime: changed Throttler to use simTime instead of realTime #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Throttler for the clock publisher to use simTime instead of realTime. This fixes gazebo_ros_pkgs#1324 and should allow ROS applications to continue to cooperate with Gazebo when the simulation is paused and is being stepped.
jmachowinski
approved these changes
Oct 5, 2023
|
Bump, as we ran into this one. @scpeters please review this. |
scpeters
approved these changes
Oct 5, 2023
scpeters
changed the title
|
thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
Throttlerfor the clock publisher in gazebo_ros_init.cpp to usesimTimeinstead ofrealTime. This should fix #1324 and should allow ROS applications to continue to cooperate with Gazebo when the simulation is paused and is being stepped.If this doesn't break anything, I can open new PRs for the rest of the ros2 distro-specific branches (foxy, galactic, etc) that have the same issue.