Use generic SIGINT parameter in kill command for gazebo script #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kev-the-dev
reviewed
May 22, 2018
gazebo_ros/scripts/gazebo
Outdated
| GAZEBO_MASTER_URI="$desired_master_uri" GAZEBO_MODEL_DATABASE_URI="$desired_model_database_uri" gzserver $final & | ||
| gzserver_pid="$!" | ||
| # Use kill -0 to check if the process is running | ||
| if $(kill -0 $! > /dev/null); then |
There was a problem hiding this comment.
Recommend redirecting stderr 2> instead of stdout because kill will write to stderr if that process does not exist.
There was a problem hiding this comment.
Otherwise worked great in my testing!
scpeters
approved these changes
May 24, 2018
This was referenced May 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #485
Use the
-Nnotation for send-2to the kill command ofgzserver. It is supported in both Mac and Linux. I added some checks withkill -0to check that the process is indeed running.