Add the ability to have deadman axes. #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Friendly ping on this one; any thoughts? |
|
Looks good to me at first but currently I have no means to test this. @artivis please chime in |
|
Looks good, I'll try to test this over the weekend. |
|
Another friendly ping. I've been using this on the robot I'm working on, and seems to work in my testing. Any chance we can get this merged? Thanks! |
|
Another ping here; would someone mind merging this? Thanks. |
Some controllers don't have a convenient shoulder trigger button, but do have shoulder "axes". Allow the axes to be used for a deadman trigger, assuming they are pressed all the way. Note that I used a dict for the list of axes, as this provides the most convenient way to deal with controllers that use 1.0, -1.0, or 0.0 as the "far" end of the axis. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some controllers don't have a convenient shoulder trigger
button, but do have shoulder "axes". Allow the axes to
be used for a deadman trigger, assuming they are pressed
all the way. Note that I used a dict for the list of
axes, as this provides the most convenient way to deal
with controllers that use 1.0, -1.0, or 0.0 as the "far"
end of the axis.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org