Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 compatibility for noetic #52

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Conversation

Timple
Copy link
Contributor

@Timple Timple commented May 26, 2020

As a start for #51

I've never used the mouse teleop and I don't think that one is easy to verify in dockers.

So we could release this as-is or wait for someone to validate functionality.

@bmagyar
Copy link
Member

bmagyar commented May 26, 2020

I've just merged a long-standing PR that caused a minor conflict, could you please rebase and touch that one up?

My question regarding this PR is, whether you think it could actually go into Kinetic/Melodic also? The proposed changes seem compatible but I'm not sure about the package.xml versioning constraints

@Timple
Copy link
Contributor Author

Timple commented May 26, 2020

The reason I choose for the conditions in the package.xml is to keep things backward compatible.

Otherwise we can create a noetic-devel branch without the conditions.

But since all active ROS1 distributions are supported now by the kinetic-devel branch, perhaps rename that one to ros1-devel? But that would not be backwards compatible for people building from source maybe..

edit: and to answer your question, conditions work in kinetic: https://answers.ros.org/question/286969/use-identical-packagexml-for-ros1-and-ros2-pkgs/?answer=287026#post-id-287026

@bmagyar bmagyar merged commit 867ad6a into ros-teleop:kinetic-devel Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants