Run colcon-coveragepy-result to collect all Python coverage data #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piraka9011
approved these changes
Jun 30, 2020
piraka9011
approved these changes
Jun 30, 2020
There was a problem hiding this comment.
LGTM once ros-tooling/setup-ros#208 and released so we can pin the version and test against it.
|
0.0.25 is released with the required patch |
This was referenced Jun 30, 2020
@thomas-moulard I've opened #253 for the bump to |
|
@christophebedard could you please resolve any conflicts now that #253 is in |
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
…mple Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
|
@piraka9011 done. I rebased. |
prajakta-gokhale
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
colcon-coveragepy-resultcollects the Python coverage data for pure Python packages and for CMake packages with Python code (i.e.ros.ament_cmake, see ament/ament_cmake#226) and combines it all into one file (coveragepy/.coveragerelative to the workspace).I also added an example to the README which uses the
coverage-pytestmixin. This is both abuildand atestmixin (forros.ament_cmakepackages and pure Python packages, respectively).Part of #238
Requires ros-tooling/setup-ros#208
Note: I'm not entirely sure why I have all these changes; I think I have the right packages/versions.