Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DEBIAN_FRONTEND=noninteractive in Linux #701

Merged

Conversation

kenji-miyake
Copy link
Contributor

@kenji-miyake kenji-miyake commented Aug 13, 2021

I found action-ros-ci will freeze when there are some interactive packages in dependencies.
https://github.com/kenji-miyake/grid_map/pull/1/checks?check_run_id=3324912225
image

So I added DEBIAN_FRONTEND=noninteractive in Linux and tested it below.
https://github.com/kenji-miyake/grid_map/pull/2/checks?check_run_id=3325170640

image

Note: This PR is based on #700. I will rebase this PR after #700 is merged.

@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #701 (bdd9ec9) into master (c69b164) will not change coverage.
The diff coverage is 0.00%.

❗ Current head bdd9ec9 differs from pull request most recent head 44034a4. Consider uploading reports for the commit 44034a4 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #701   +/-   ##
=======================================
  Coverage   48.78%   48.78%           
=======================================
  Files           2        2           
  Lines         246      246           
  Branches       57       56    -1     
=======================================
  Hits          120      120           
  Misses        126      126           
Impacted Files Coverage Δ
src/action-ros-ci.ts 41.93% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c69b164...44034a4. Read the comment docs.

Copy link
Contributor

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the change is just the single variable - this also LGTM

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@kenji-miyake
Copy link
Contributor Author

Rebased to upstream/master.

@kenji-miyake kenji-miyake marked this pull request as ready for review August 14, 2021 23:46
@kenji-miyake kenji-miyake requested a review from a team as a code owner August 14, 2021 23:46
@kenji-miyake kenji-miyake requested review from MichaelOrlov and prajakta-gokhale and removed request for a team August 14, 2021 23:46
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@christophebedard christophebedard enabled auto-merge (squash) August 15, 2021 00:03
@christophebedard christophebedard merged commit e2294db into ros-tooling:master Aug 15, 2021
@kenji-miyake kenji-miyake deleted the add-noninteractive-option branch August 15, 2021 00:29
@kenji-miyake
Copy link
Contributor Author

@christophebedard By the way, when do you plan to release the next patch version?

@christophebedard
Copy link
Member

@kenji-miyake I can't do a proper release myself since I can't push to master directly. @emersonknapp will have to do it when he's available (unless someone else with the appropriate permissions does it), but I think he might be on vacation this week.

@kenji-miyake
Copy link
Contributor Author

I understand, thank you! I'm not in a hurry, but I just wanted to know your regular schedule.

@emersonknapp
Copy link
Contributor

emersonknapp commented Aug 24, 2021

Yeah - I was on vacation last week. We can get a release out this week - there isn't a regular schedule, just whenever it seems like there are a few good features and we get to it. @christophebedard if you want to open a PR I'm happy to approve it. I think we have this repo configured to prevent direct push to master for everybody, as a bit of checks and balances. Though theoretically I could disable that feature I also generally prefer to send myself through a code review as well haha

@christophebedard
Copy link
Member

@emersonknapp 😆 yeah sounds good! PR is #702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants