-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DEBIAN_FRONTEND=noninteractive in Linux #701
Add DEBIAN_FRONTEND=noninteractive in Linux #701
Conversation
Codecov Report
@@ Coverage Diff @@
## master #701 +/- ##
=======================================
Coverage 48.78% 48.78%
=======================================
Files 2 2
Lines 246 246
Branches 57 56 -1
=======================================
Hits 120 120
Misses 126 126
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the change is just the single variable - this also LGTM
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
27bd95f
to
44034a4
Compare
Rebased to upstream/master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
@christophebedard By the way, when do you plan to release the next patch version? |
@kenji-miyake I can't do a proper release myself since I can't push to master directly. @emersonknapp will have to do it when he's available (unless someone else with the appropriate permissions does it), but I think he might be on vacation this week. |
I understand, thank you! I'm not in a hurry, but I just wanted to know your regular schedule. |
Yeah - I was on vacation last week. We can get a release out this week - there isn't a regular schedule, just whenever it seems like there are a few good features and we get to it. @christophebedard if you want to open a PR I'm happy to approve it. I think we have this repo configured to prevent direct push to master for everybody, as a bit of checks and balances. Though theoretically I could disable that feature I also generally prefer to send myself through a code review as well haha |
@emersonknapp 😆 yeah sounds good! PR is #702 |
I found
![image](https://user-images.githubusercontent.com/31987104/129409506-daee9277-dc6a-4f54-942e-4ca4ad25202d.png)
action-ros-ci
will freeze when there are some interactive packages in dependencies.https://github.com/kenji-miyake/grid_map/pull/1/checks?check_run_id=3324912225
So I added
DEBIAN_FRONTEND=noninteractive
in Linux and tested it below.https://github.com/kenji-miyake/grid_map/pull/2/checks?check_run_id=3325170640
Note: This PR is based on #700. I will rebase this PR after #700 is merged.