Add ROS environment variables to options #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenji-miyake
requested review from
christophebedard and
zmichaels11
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #700 +/- ##
==========================================
- Coverage 49.38% 47.96% -1.42%
==========================================
Files 2 2
Lines 243 246 +3
Branches 53 57 +4
==========================================
- Hits 120 118 -2
- Misses 123 128 +5
Continue to review full report at Codecov.
|
kenji-miyake
commented
Aug 11, 2021
kenji-miyake
force-pushed
the
define-env-for-rosdep
branch
from
bacef52
to
4607215
Compare
kenji-miyake
force-pushed
the
define-env-for-rosdep
branch
from
5d517dd
to
c13ece1
Compare
added 2 commits
August 14, 2021 03:58
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
kenji-miyake
force-pushed
the
define-env-for-rosdep
branch
from
c13ece1
to
2532227
Compare
kenji-miyake
changed the title
emersonknapp
approved these changes
Aug 13, 2021
Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com> Run npm commands Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
kenji-miyake
force-pushed
the
define-env-for-rosdep
branch
from
084ee6f
to
934b760
Compare
christophebedard
approved these changes
Aug 14, 2021
There was a problem hiding this comment.
This is a great enhancement! Thank you very much for iterating @kenji-miyake!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refinement of #697
In order to support dependencies with conditions like
<depend condition="$ROS_VERSION == 2">, I addedROS_VERSIONandROS_PYTHON_VERSIONininstall_rosdeps.sh.The followings are my test results.
(condition-dependency isn't in ros2.repos)
(condition-dependency is in ros2.repos)
The difference between
3and4is whether the environment variables are required in therosdep installstep.3requires and4doesn't.Note: In some PRs,
rollingtest is failed, but it's not related to this PR.