-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds rosdep-skip-keys option. #753
Adds rosdep-skip-keys option. #753
Conversation
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
Codecov Report
@@ Coverage Diff @@
## master #753 +/- ##
==========================================
+ Coverage 49.61% 50.18% +0.56%
==========================================
Files 2 2
Lines 262 267 +5
Branches 68 71 +3
==========================================
+ Hits 130 134 +4
- Misses 132 133 +1
Continue to review full report at Codecov.
|
Thanks for the PR! Can you think of a way to add a test? For example, you could add a test case in .github/workflows/test.yml that uses this new option for a set of packages, then you verify that a skipped dependency wasn't installed (and maybe check that it is installed otherwise). Doesn't need to be a complicated test. |
Thanks for the suggestion. And if it fails then the test will fail. How can I avoid it to fail so I can verify later on that the dependency isn't installed? |
If this was always the case, this You could find a repo that has a If you're not sure how to do it, I can add a test later, after this PR. |
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
Haha good point! In our case we are bringing a cmake package (non-colcon package) to the workspace
I ended reusing one of the repos file used for other test. I am just skipping a test dependency, not building the test and then verifying that effectively the package isn't installed. Please check 673ce05 |
That's perfect! Thank you :) Now I'll just let CI finish. |
Thanks for the new feature! |
Thanks @christophebedard for the immediate release 🚀 |
Resolves #276
Summary
Adds an input option for passing the keys that are intended to be skipped during
rosdep install
commandExpected to be use as