Design document for keyboard handler #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Orlov <morlovmr@gmail.com>
Signed-off-by: Michael Orlov <morlovmr@gmail.com>
…ss event got destructed before keyboard handler. Signed-off-by: Michael Orlov <morlovmr@gmail.com>
… redirected to the file or stream Signed-off-by: Michael Orlov <morlovmr@gmail.com>
…forms and abnormal program termination via Ctrl+C. Signed-off-by: Michael Orlov <morlovmr@gmail.com>
…fiers to the callbacks Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
emersonknapp
pushed a commit
that referenced
this pull request
Jun 16, 2021
* Initial creation of the keyboard handler design document Signed-off-by: Michael Orlov <morlovmr@gmail.com> * Add design requirements Signed-off-by: Michael Orlov <morlovmr@gmail.com> * Add content for the case when client's code subscribed to the key press event got destructed before keyboard handler. Signed-off-by: Michael Orlov <morlovmr@gmail.com> * Add content for the case when standard input from terminal or console redirected to the file or stream Signed-off-by: Michael Orlov <morlovmr@gmail.com> * Add content for handling input from keyboard on POSIX compatible platforms and abnormal program termination via Ctrl+C. Signed-off-by: Michael Orlov <morlovmr@gmail.com> * Update design doc with new API changes related to the adding key modifiers to the callbacks Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Added `known issues` section to the design document. Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
sloretz
added a commit
to sloretz/keyboard_handler
that referenced
this pull request
Jan 14, 2022
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design document for keyboard handler package.
Relates to the #735
Part of the #696
Moved content from ros2/rosbag2#768.
Also updated API with key modifiers in callbacks and added new section with known issues and design/implementation limitations.