Use rosidl_get_typesupport_target()

[sloretz]

Part of ros2/rosidl#606 which deprecates rosidl_target_interfaces() in favor of rosidl_get_typesupport_target()

[sloretz]

Is someone with write access on this repo available to merge this in a few minutes?

The upstream pr ros2/rosidl#606 is ready to merge, but I'd like to merge all downstream PRs quickly to minimize the number of CI jobs with a CMake warning.

[emersonknapp]

Done - saw the passing CI on ros2/rosidl#606

[christophebedard]

This is breaking Galactic builds because the master branch here is used for both Rolling and Galactic:

• https://github.com/ros/rosdistro/blob/d32b707cd78ba1c63972b870826a5b434abdc7ff/galactic/distribution.yaml#L1357
• https://github.com/ros2/ros2/blob/1af04b49329d43c54c63bcf1a9302f9462ec1263/ros2.repos#L73

We should probably create a galactic/galactic-devel branch and point it to the commit before this one.

[christophebedard]

I created a https://github.com/ros-tooling/libstatistics_collector/tree/galactic-devel branch pointing to the last commit before this one and opened ros2/ros2#1166 as a proposed fix. We'll need to update the branch in the Galactic distribution file and in https://github.com/ros2-gbp/libstatistics_collector-release/blob/master/tracks.yaml too.

[emersonknapp]

Thanks for creating the branch! I'll do a bloom-edit now into galactic to update the tracks

[emersonknapp]

As a note, I'm going to go with galactic branch to match other projects going forward - i've never been a fan of the -devel branch naming.

[emersonknapp]

tracks is updated https://github.com/ros2-gbp/libstatistics_collector-release/blob/master/tracks.yaml#L41

[mjcarroll]

This looks like this has broken some of the galactic nightlies.

For example: https://build.ros2.org/view/Gci/job/Gci__nightly-release_ubuntu_focal_amd64/30/console#console-section-13

And the error is:

10:39:27 --- stderr: libstatistics_collector
10:39:27 CMake Error at CMakeLists.txt:100 (rosidl_get_typesupport_target):
10:39:27   Unknown CMake command "rosidl_get_typesupport_target".
10:39:27 
10:39:27 
10:39:27 ---

Is this using a feature that should have only been targeted at rolling?

[sloretz]

Is this using a feature that should have only been targeted at rolling?

Definitely. I think ROS Galactic CI should be fixed by ros/rosdistro#30426

[emersonknapp]

Those have just been updated in rosdistro to use galactic branch instead of master - I don't know how long that would take to go through?
ros/rosdistro#30411
ros/rosdistro#30426

[mjcarroll]

Thanks @emersonknapp and @sloretz. Looks like rosdep has been merged and everything should be happy by next go-around.