Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set libstatistics_collector to galactic for Galactic #1166

Merged
merged 2 commits into from Aug 9, 2021
Merged

Set libstatistics_collector to galactic for Galactic #1166

merged 2 commits into from Aug 9, 2021

Conversation

christophebedard
Copy link
Member

@christophebedard christophebedard commented Aug 5, 2021 •
edited

ros-tooling/libstatistics_collector#116 broke Galactic builds because libstatistics_collector's master branch is used for Rolling and Galactic, but ros2/rosidl#606 is only in Rolling.

The galactic branch points to a commit before ros-tooling/libstatistics_collector#116: https://github.com/ros-tooling/libstatistics_collector/tree/galactic

Signed-off-by: Christophe Bedard bedard.christophe@gmail.com

@christophebedard
Set libstatistics_collector to galactic-devel
954f5a8 
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
@christophebedard christophebedard mentioned this pull request Aug 5, 2021
Merged
clalancette
clalancette approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, but I'd like to have @cottsay take a look before merging. You'll also have to update https://github.com/ros2-gbp/libstatistics_collector-release/blob/master/tracks.yaml to point to the correct branch for galactic.

emersonknapp
emersonknapp reviewed Aug 5, 2021
View reviewed changes
ros2.repos Outdated Show resolved Hide resolved
@christophebedard
Rename branch to galactic
6d60cd6 
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
@christophebedard christophebedard changed the title Set libstatistics_collector to galactic-devel for Galactic Set libstatistics_collector to galactic for Galactic Aug 5, 2021
@emersonknapp
Copy link
Contributor

Tracks is updated https://github.com/ros2-gbp/libstatistics_collector-release/blob/master/tracks.yaml#L41

@cottsay
Copy link
Member

cottsay commented Aug 6, 2021

Can someone also update the doc and source stanzas in ros/rosdistro? https://github.com/ros/rosdistro/blob/4cf62ef1e90762fb83fbfcbe3d736f3a98654d13/galactic/distribution.yaml#L1344-L1358

@christophebedard christophebedard mentioned this pull request Aug 7, 2021
Merged
@christophebedard
Copy link
Member Author

Can someone also update the doc and source stanzas in ros/rosdistro? ros/rosdistro@4cf62ef/galactic/distribution.yaml#L1344-L1358

@cottsay done here ros/rosdistro#30426

christophebedard referenced this pull request in ros-tooling/libstatistics_collector Aug 7, 2021
@sloretz
Use rosidl_get_typesupport_target() (#116)
1d3b165 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@clalancette clalancette merged commit c7c318e into ros2:galactic Aug 9, 2021
@christophebedard christophebedard deleted the set-libstatistics-collector-to-galactic-devel branch August 9, 2021 12:36
@YHuniv
Copy link

YHuniv commented Nov 28, 2023

sudo apt-get install ros-galactic-rosidl-default-generators ros-galactic-rosidl-default-runtime

this resolved my problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@emersonknapp emersonknapp emersonknapp approved these changes

@cottsay cottsay cottsay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@christophebedard @emersonknapp @cottsay @YHuniv @clalancette