Update QD to QL 1 #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Brawner <brawner@gmail.com>
brawner
requested review from
thomas-moulard and
prajakta-gokhale
and removed request for
a team
chapulina
approved these changes
Nov 25, 2020
| @@ -145,31 +153,31 @@ Currently nightly test results can be seen here: | |||
|
|
|||
| The `rcl` package supports implementation of language specific ROS Client Libraries. | |||
|
|
|||
| It is **Quality Level 2**, see its [Quality Declaration document](https://github.com/ros2/rcl/blob/master/rcl/QUALITY_DECLARATION.md). | |||
| It is **Quality Level 1**, see its [Quality Declaration document](https://github.com/ros2/rcl/blob/master/rcl/QUALITY_DECLARATION.md). | |||
|
|
||
| #### `rosidl_default_runtime` | ||
|
|
||
| The `rosidl_default_runtime` provides CMake functionality for finding and adding runtime dependencies for rosidl packages. | ||
|
|
||
| It is **Quality Level 2**, see its [Quality Declaration document](https://github.com/ros2/rosidl_defaults/blob/master/rosidl_default_runtime/QUALITY_DECLARATION.md). | ||
| It is **Quality Level 1**, see its [Quality Declaration document](https://github.com/ros2/rosidl_defaults/blob/master/rosidl_default_runtime/QUALITY_DECLARATION.md). |
|
|
||
| #### `statistics_msgs` | ||
|
|
||
| The `statistics_msgs` package contains ROS 2 message definitions for reporting statistics for topics and system resources. | ||
|
|
||
| It is **Quality Level 2**, see its [Quality Declaration document](https://github.com/ros2/rcl_interfaces/blob/master/statistics_msgs/QUALITY_DECLARATION.md). | ||
| It is **Quality Level 1**, see its [Quality Declaration document](https://github.com/ros2/rcl_interfaces/blob/master/statistics_msgs/QUALITY_DECLARATION.md). |
|
|
||
| #### `std_msgs` | ||
|
|
||
| The `std_msgs` package provides many basic message types. | ||
|
|
||
| It is **Quality Level 2**, see its [Quality Declaration document](https://github.com/ros2/common_interfaces/blob/master/std_msgs/QUALITY_DECLARATION.md). | ||
| It is **Quality Level 1**, see its [Quality Declaration document](https://github.com/ros2/common_interfaces/blob/master/std_msgs/QUALITY_DECLARATION.md). |
There was a problem hiding this comment.
Depends on ros2/common_interfaces#135
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
===========================================
- Coverage 48.08% 24.75% -23.33%
===========================================
Files 1512 27 -1485
Lines 41806 820 -40986
Branches 18500 185 -18315
===========================================
- Hits 20102 203 -19899
+ Misses 5404 454 -4950
+ Partials 16300 163 -16137
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
All upstream PRs are in. Could some maintainer take a quick look and get this in? Maybe @dabonnie ? Thanks! |
prajakta-gokhale
approved these changes
Nov 25, 2020
dabonnie
approved these changes
Nov 25, 2020
|
Looks like we're close to merging! 😏 😇 |
brawner
added a commit
to brawner/libstatistics_collector
that referenced
this pull request
Nov 26, 2020
Signed-off-by: Stephen Brawner <brawner@gmail.com>
emersonknapp
pushed a commit
that referenced
this pull request
Nov 30, 2020
* Update QD to QL 1 (#68) Signed-off-by: Stephen Brawner <brawner@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chapulina tagging you here because this is in the ros-tooling org.
Signed-off-by: Stephen Brawner brawner@gmail.com