Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if message's "header" field is of type std_msgs::msg::Header #54

Merged
merged 14 commits into from
Sep 28, 2022
Merged

Check if message's "header" field is of type std_msgs::msg::Header #54

merged 14 commits into from
Sep 28, 2022

Commits on Sep 23, 2022

  1. Fix for Issue 51. Adds check to HasHeader template to check header me… 

    …mber has type Header. Added unit test case and DummyCustomHeaderMessage for use with tests.

Signed-off-by: Scott Mende

Signed-off-by: scott.mende@sslmda.com <scott.mende@sslmda.com>
    @clalancette
    scott.mende@sslmda.com authored and clalancette committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    d7757df View commit details
    Browse the repository at this point in the history

  2. Fix reference to Header to std_msgs::msg::Header 

    Signed-off-by: Scott Mende

Signed-off-by: scott.mende@sslmda.com <scott.mende@sslmda.com>
    @clalancette
    scott.mende@sslmda.com authored and clalancette committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    3767962 View commit details
    Browse the repository at this point in the history

  3. Fix style divergence. 

    Signed-off-by: Scott Mende
Signed-off-by: scott.mende@sslmda.com <scott.mende@sslmda.com>
    @clalancette
    scott.mende@sslmda.com authored and clalancette committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    5a570dd View commit details
    Browse the repository at this point in the history

  4. Add std_msgs as a <test_depend>. 

    Signed-off-by: scott.mende@sslmda.com <scott.mende@sslmda.com>
    @clalancette
    scott.mende@sslmda.com authored and clalancette committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    139a3a3 View commit details
    Browse the repository at this point in the history

  5. Add missing dependency 

    Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
    @dabonnie @clalancette
    dabonnie authored and clalancette committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    566926c View commit details
    Browse the repository at this point in the history

  6. Fix build 

    Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
    @emersonknapp @clalancette
    emersonknapp authored and clalancette committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    e14bb48 View commit details
    Browse the repository at this point in the history

  7. Remove redundant std_msgs depends. 

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    dbd714b View commit details
    Browse the repository at this point in the history

  8. Working version with checking for header.stamp 

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    cf3cfe8 View commit details
    Browse the repository at this point in the history

  9. Remove one more unnecessary std_msgs dependency. 

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    5140e0b View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2022

  1. Make it work by checking the type of the stamp field. 

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    ca5cd77 View commit details
    Browse the repository at this point in the history

  2. Add std_msgs dependency back. 

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    199ef66 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2022

  1. Make sure the header also has a frame_id. 

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    929ad82 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary comment. 

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    24bb7d3 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2022

  1. Revert "Make sure the header also has a frame_id." 

    This reverts commit 929ad82.
    @clalancette
    clalancette committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    ec04cc8 View commit details
    Browse the repository at this point in the history