-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/transform #17
Conversation
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Add transform Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
29d2c94
to
29f0568
Compare
My major concern here is that the Python linters are not run on this script - probably because it doesn't end in Could you make it so that the linters run on this new source? Probably you could strip the |
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
c23e613
to
efb3945
Compare
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
@emersonknapp I use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the change - I think this looks good to me
@emersonknapp @wep21 , the fact that |
@mateusz-lichota I created a PR to address the isseu you suggested. Please check it out. #18 |
Thanks for the work @wep21 - I have merged that PR |
This reverts commit 4151102. Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
This reverts commit 4151102. Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
This reverts commit 4151102. Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
This reverts commit 4151102. Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp> Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
Add transform from https://github.com/ros/ros_comm/blob/noetic-devel/tools/topic_tools/scripts/transform
http://wiki.ros.org/topic_tools/transform