Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[windows] add visibility control and install binaries to portable locations #62

Merged
merged 1 commit into from
Mar 16, 2020
Merged

[windows] add visibility control and install binaries to portable locations #62

merged 1 commit into from
Mar 16, 2020

Conversation

seanyen
Copy link
Contributor

@seanyen seanyen commented Feb 14, 2020 •
edited
Loading

cherry-pick Windows specific fixes from ROS2:

@seanyen
Copy link
Contributor Author

seanyen commented Feb 14, 2020

@tfoote @dgossow This is ready for review and merge. Thanks!

@dgossow
Copy link
Member

dgossow commented Feb 14, 2020

lgtm
@tfoote perhaps weigh in if you have additional comments

@tfoote tfoote self-requested a review February 21, 2020 00:34
@seanyen
Copy link
Contributor Author

seanyen commented Mar 5, 2020

@tfoote Friendly ping.

@dgossow dgossow changed the base branch from indigo-devel to kinetic-devel March 16, 2020 08:03
@dgossow dgossow merged commit a45551b into ros-visualization:kinetic-devel Mar 16, 2020
@dgossow
Copy link
Member

dgossow commented Mar 16, 2020

@seanyen merging this to kinetic-devel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfoote tfoote tfoote approved these changes

@dgossow dgossow dgossow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seanyen @dgossow @tfoote