Port to ROS 2 #44
Merged
Port to ROS 2 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Now with .hpp suffix Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
This satisfies the ament_copyright linter. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Using this abstract interface enables use of the interactive marker client with other buffer implementations. Also, switched to using shared pointers to avoid potential dangling reference. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
It seems more intuitive for clients to call a service to get the latest state for interactive markers, versus subscribing to a latched topic and waiting for the server to publish. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Failing tests are commented out for now. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Useful for introspection, especially during testing. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Failing tests are commented out. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Merge SingleClient logic into InteractiveMarkerClient. Now it is assumed that there is maximum one server per client. This helps simplify the implementation. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Update doc-block comment style * Fix tests * Renaming of variables for clarity Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
The functionality it provided is not needed. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
|
Attempt to resolve various compiler warnings on macOS and Windows:
|
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
This reverts commit aae3258.
|
I think this is pretty much ready for review, while I debug the Windows warnings and try to figure out why Clang and GCC disagree on what type something is. |
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Adding UNUSED macro arguments fixes "too many arguments" and "too few arguments" warnings. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
|
I think I've worked out all the issues with the Windows build 🤞
|
wjwwood
approved these changes
Aug 29, 2019
|
I was so close... but an expected test error message is being picked up as a MSBuild warning 😞 |
|
The latest MSBuild warning is a false positive; an instance of ros2/ci#316. |
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
|
Windows: |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a heavy refactor of the original code following the proposal in #42.
This is a work-in-progress, but opening for visibility and early feedback.
Some things still to do:
Add liveliness check between server and client.Before polishing this, I plan to get it working with the RVIz display and write a standalone node showing how we can bridge with ROS 1.
Resolves #42
Depends on ros2/common_interfaces#70