Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add windows, c++17 and external project support to shiboken_helper.cmake #116

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Add windows, c++17 and external project support to shiboken_helper.cmake #116

merged 1 commit into from
Mar 1, 2023

Conversation

hellantos
Copy link
Contributor

@hellantos hellantos commented Aug 30, 2022 •
edited
Loading

This improves shiboken support.

  • Adds pyside_config.py for help finding pyside and shiboken when installed on windows with pip
  • Adds c++17 support for shiboken2 generation
  • Adds support for building bindings in a seperate package and cmake project

This is related to #114 as well as #103.
This is tested (it doesn't break build on Ubuntu) with and a prerequisit for ros2/rviz#889

@hellantos hellantos changed the title Add windows support for pyside helper Add windows, c++17 and external project support to shiboken_helper.cmake Aug 30, 2022
@hellantos hellantos marked this pull request as ready for review August 30, 2022 15:21
@hellantos hellantos mentioned this pull request Aug 30, 2022
Open
@mjcarroll mjcarroll merged commit 0a7f68e into ros-visualization:rolling Mar 1, 2023
@mjcarroll
Copy link
Contributor

mjcarroll commented Mar 1, 2023 •
edited
Loading

Ran locally, but for good measure:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

mjcarroll added a commit that referenced this pull request Mar 1, 2023
@mjcarroll
Revert "Add windows support for pyside helper (#116)"
1c3af37 
This reverts commit 0a7f68e.
@mjcarroll mjcarroll mentioned this pull request Mar 1, 2023
Merged
mjcarroll added a commit that referenced this pull request Mar 1, 2023
@mjcarroll
Revert "Add windows support for pyside helper (#116)" (#124)
d8fc617 
This reverts commit 0a7f68e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hellantos @mjcarroll