Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Qt variable in generated Makefile. #64

Conversation

@hgaiser
Copy link
Contributor

hgaiser commented Jun 26, 2019

This PR replaces the $$[QT_INSTALL_LIBS] variable, introduced in Qt 5.12.4.

For more info, check here.

Note: sipconfig will be unsupported in sip5, so maybe someone should spend time on replacing sipconfig with something else that is not deprecated?

@dirk-thomas

This comment has been minimized.

Copy link
Member

dirk-thomas commented Jul 29, 2019

Thanks for the patch.

so maybe someone should spend time on replacing sipconfig with something else that is not deprecated?

Please create a separate ticket for this separate task. Otherwise it is pretty likely it gets lost once this ticket is closed. Even better would be to consider contributing a pull request 😉

@dirk-thomas dirk-thomas merged commit 1b3000d into ros-visualization:kinetic-devel Jul 29, 2019
dirk-thomas added a commit that referenced this pull request Jul 29, 2019
* Replace Qt variable in generated Makefile.

* use single quotes
dirk-thomas added a commit that referenced this pull request Jul 29, 2019
* Replace Qt variable in generated Makefile.

* use single quotes
dirk-thomas added a commit that referenced this pull request Sep 30, 2019
* Replace Qt variable in generated Makefile.

* use single quotes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.