-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PySide2 and Shiboken2 targets for variables #79
Use PySide2 and Shiboken2 targets for variables #79
Conversation
Can you clarify what you mean with "hopefully"? How/ what environments and steps have you tested this patch with? |
I have not tested whether this PR breaks the build on Ubuntu/Debian or ROS Kinetic. On Arch Linux using ROS Melodic this seems to work fine. My tests which lead to the assumtion that this PR fixes some issues with new versions of PySide2 and Shiboken2:
CMake output while catkin_make_isolated runs:
So |
Tested on ROS Kinetic using docker:
Changes made in this PR are okay, but the Could not test on ROS Melodic because the installation of Could also not test on ROS Melodic with Debian Stretch because I found no PySide2 and Shiboken2 packages for Debian. |
Thank you for the pull request. In the mean time I have branched for Melodic (since Kinetic has a much older PySide version). I rebased this patch and applied some minor changes to keep the diff minimal. The most important fix I added was adding the missing With this (and ros-visualization/qt_gui_core#201) I was able to build both on Ubuntu Focal for Noetic. |
* Inserted blank lines to improve readability * Set PYSIDE_LIBRARY and PYSIDE_INCLUDE_DIR for Pyside >= 5.12 * Set SHIBOKEN_LIBRARY and SHIBOKEN_INCLUDE_DIR for newer shiboken version * Moved location where SHIBOKEN_BINARY is set, added message output * shiboken_helper.cmake: Print PYSIDE_INCLUDE_DIR and SHIBOKEN_INCLUDE_DIR * shiboken_helper.cmake: Refactor find_package for Shiboken and PySide * shiboken_helper.cmake: Include current directory, enable pyside ext. * shiboken_helper.cmake: Fixed compilation on Kinetic/Xenial * remove unnecessary whitespace changes * reorder some lines * condition can check the variable name * remove conditionally for very old shiboken versions * add CMAKE_CXX_IMPLICIT_INCLUDE_DIRECTORIES to shiboken invocation Co-authored-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
While this works on Ubuntu Focal it unfortunately doesn't work on Debian Buster: http://build.ros.org/job/Nbin_db_dB64__qt_gui_cpp__debian_buster_amd64__binary/3/ This seems to be the relevant upstream ticket which has been fixed in CMake 3.14 but Debian Buster contains 3.13.4. |
Hopefully fix #78 and continue #77.