Fixed namespace in typesystem.xml #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also had to remove the include of |
|
This should probably target only Melodic+ since in Kinetic the PySide version works with the non-patched code. I will create a new |
dirk-thomas
changed the title
This was referenced Feb 29, 2020
|
@ros-pull-request-builder retest this please |
|
Noetic passing except a compiler warning in Qt itself: http://build.ros.org/job/Npr__qt_gui_core__ubuntu_focal_amd64/11/warnings24Result/ |
dirk-thomas
added a commit
that referenced
this pull request
Mar 2, 2020
* Fixed namespace in typesystem.xml * remove include of pyside2_global.h Co-authored-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
|
Cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeting ros-melodic-arch/ros-melodic-qt-gui-cpp#12.