Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix build type of qt_dotcode #155

Merged
merged 1 commit into from
Dec 11, 2018
Merged

fix build type of qt_dotcode #155

merged 1 commit into from
Dec 11, 2018

Conversation

dirk-thomas
Copy link
Contributor

Follow up of #135.

@ghost ghost assigned dirk-thomas Dec 11, 2018
@ghost ghost added the in progress label Dec 11, 2018
@dirk-thomas dirk-thomas mentioned this pull request Dec 11, 2018
Merged
brawner
brawner approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@brawner brawner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this :(

@dirk-thomas
Copy link
Contributor Author

CI is marked "failed' due to the three CMake warnings about PySide2.

@dirk-thomas dirk-thomas merged commit 27e9a4d into crystal-devel Dec 11, 2018
@dirk-thomas dirk-thomas deleted the fix-build-type branch December 11, 2018 17:11
@ghost ghost removed the in progress label Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brawner brawner brawner approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dirk-thomas @brawner