-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cast drawLine input arguments to int #264
Cast drawLine input arguments to int #264
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix LGTM.
I have a minor comment about style.
Thanks for the contribution!!
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the requested fixes on this PR, and this fixes the issue for me. I'm going to go ahead and run CI on this, and also port it over to the 'rolling' branch.
The warning has nothing to do with this PR (though I'm not honestly sure why we see it in CI and not on the nightlies). Regardless, I'm going to go ahead and merge this one in. |
@Mergifyio backport rolling |
✅ Backports have been created
|
* Cast drawLine input arguments to int Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit e0e1505)
I was getting the following error and resulting crash when using
rqt_graph
on humble with python 3.10.Explicitly casting the inputs to int seems to resolve this issue.