Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix unload warning #274

Merged
merged 2 commits into from May 16, 2023
Merged

fix unload warning #274

merged 2 commits into from May 16, 2023

Conversation

iuhilnehc-ynos
Copy link
Contributor

to fix part of osrf/ros2_test_cases#1048

Warning: class_loader.ClassLoader: SEVERE WARNING!!! Attempting to unload library while objects created by this loader exist in the heap! You should delete your objects before attempting to unload the library or destroying the ClassLoader. The library will NOT be unloaded.
         at line 127 in ./src/class_loader.cpp

fix unload warning
b02e9c3 
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
@iuhilnehc-ynos iuhilnehc-ynos mentioned this pull request May 11, 2023
Merged
adjust order for header file
08a5cb7 
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
@Yadunund Yadunund self-requested a review May 11, 2023 08:28
@Yadunund
Copy link
Member

Tested locally and works well!

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@Yadunund Yadunund merged commit 1cd7985 into ros-visualization:rolling May 16, 2023
2 checks passed
@clalancette
Copy link
Contributor

@Mergifyio backport iron

@mergify
Copy link
Contributor

mergify bot commented May 16, 2023 •
edited

backport iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 16, 2023
@mergify
fix unload warning (#274)
f6a261e 
* fix unload warning

Signed-off-by: Chen Lihui <lihui.chen@sony.com>

* adjust order for header file

Signed-off-by: Chen Lihui <lihui.chen@sony.com>

---------

Signed-off-by: Chen Lihui <lihui.chen@sony.com>
(cherry picked from commit 1cd7985)
@mergify mergify bot mentioned this pull request May 16, 2023
Merged
clalancette pushed a commit that referenced this pull request May 16, 2023
@mergify
fix unload warning (#274) (#275)
3ebe59a 
* fix unload warning

Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yadunund Yadunund Awaiting requested review from Yadunund

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iuhilnehc-ynos @Yadunund @clalancette