qt_gui_cpp_sip: Add python include dirs

[NikolausDemmel]

I need a change to this effect to compile on OSX 10.9

[dirk-thomas]

I don't think that this is the right location to address your problem. Instead python_qt_binding should be able to take care of this in a more generic way (without requiring every package which uses sip to deal with it).

Please use the latest checkouts of all repos since some related issues have recently been fixed already - may be the problem is already fixed by these changes:

• Fix find_package(PythonLibs ...) ros/rospack#42
• fix finding specific version of PythonLibs with CMake 3 ros/ros_comm#453
• fix finding specific version of PythonLibs with CMake 3 python_qt_binding#11
• fix PythonLibs include #45

If the issue still exists can you please try to address the problem in the following file instead? https://github.com/ros-visualization/python_qt_binding/blob/groovy-devel/cmake/sip_helper.cmake

[NikolausDemmel]

I don't think this is related to any of the cmake 3.0.0

set(PythonLibs_FIND_VERSION "${PYTHON_VERSION_MAJOR}.${PYTHON_VERSION_MINOR}")
find_package(PythonLibs REQUIRED)

vs

find_package(PythonLibs "${PYTHON_VERSION_MAJOR}.${PYTHON_VERSION_MINOR}" REQUIRED)

issues (which don't seem to affect me anyway). I wounder why this ever worked in the first place on systems where the Python.h doesn't happen to be in a folder that is added to the include paths by some other means.

It seems that adding find_package(PythonLibs "${PYTHON_VERSION_MAJOR}.${PYTHON_VERSION_MINOR}" REQUIRED) to sip_helper.cmake and then including the header files in the sip command directly might be the right thing.

[dirk-thomas]

Can you please provide a pull request for python_qt_binding which works for you?

[dirk-thomas]

Closing this in favor of the new PR: ros-visualization/python_qt_binding#12