Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add a dependency on pytest to rqt_bag and rqt_bag_plugins. (#… #151

Merged
merged 1 commit into from Feb 12, 2024

Conversation

clalancette
Copy link

…148)"

This reverts commit f0a47cf.

The main reason to do this is that on Windows Debug, we don't currently have a Debug wheel for PyQt. Thus these tests always fail on that platform. While the "correct" solution is to build a Windows Debug PyQt wheel, that is a decidedly difficult undertaking. Since we don't have tests to speak of in these packages, avoid the problem for now by just going back to what we were doing before, i.e. using unittest for the tests.

This should fix part of the failing Windows Debug nightlies, like https://ci.ros2.org/view/nightly/job/nightly_win_deb/2999/

)"

This reverts commit f0a47cf.

The main reason to do this is that on Windows Debug, we don't currently
have a Debug wheel for PyQt.  Thus these tests always fail on that
platform.  While the "correct" solution is to build a Windows Debug
PyQt wheel, that is a decidedly difficult undertaking.  Since we
don't have tests to speak of in these packages, avoid the problem
for now by just going back to what we were doing before, i.e.
using unittest for the tests.
@clalancette
Copy link
Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status
  • Windows Debug Build Status

@clalancette clalancette merged commit 1590102 into rolling Feb 12, 2024
1 check passed
@clalancette clalancette deleted the clalancette/revert-pytest branch February 12, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants