Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamically resize the timeline when recording #66

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Dynamically resize the timeline when recording #66

merged 1 commit into from
Oct 20, 2020

Conversation

mjeronimo
Copy link
Contributor

Previously, when recording, once the timeline window had filled with messages,
additional messages were not displayed. Instead, the window appeared static,
even while recording continued.

Now, the timeline window incorporates any newly recorded messages, resizing
as needed in order to dynamically update the window.

Signed-off-by: Michael Jeronimo michael.jeronimo@openrobotics.org

@mjeronimo
Dynamically resize the timeline when recording
01c49f1 
Previously, when recording, once the timeline window had filled with messages,
additional messages were not displayed. Instead, the window appeared static,
even while recording continued.

Now, the timeline window incorporates any newly recorded messages, resizing
as needed in order to dynamically update the window.

Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
mabelzhang
mabelzhang reviewed Oct 16, 2020
View reviewed changes
Copy link

@mabelzhang mabelzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

Before, I had to manually scroll to see the new messages off the screen:
2020-10-16-01-51_rqtbagOrigBehavior

After:
2020-10-16-01-54_rqtbagDynamicResize

I'm not familiar with ROS 1 CI. Do we need to run CI on this / if so, could you run CI on it?

@mjeronimo
Copy link
Contributor Author

@dirk-thomas Is there a historical reason that this package doesn't have 'test_pull_requests' enabled on rosdistro? Should this flag be added to the active ROS1 distributions?

@dirk-thomas
Copy link
Contributor

Is there a historical reason that this package doesn't have 'test_pull_requests' enabled on rosdistro?

The packages don't have any tests so why should there be a pull request job?

@mjeronimo
Copy link
Contributor Author

I was thinking about ensuring that there were no build issues on target platforms other than that used by the developer.

Now that you mention it though, has there been any automated testing of GUI apps so far?

mabelzhang
mabelzhang approved these changes Oct 20, 2020
View reviewed changes
Copy link

@mabelzhang mabelzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since there is no CI for GUI or standard static analysis as discussed in meeting.

@mjeronimo mjeronimo merged commit c10a3b9 into master Oct 20, 2020
mjeronimo added a commit that referenced this pull request Oct 20, 2020
@mjeronimo
Dynamically resize the timeline when recording (#66)
b182e6f 
Previously, when recording, once the timeline window had filled with messages,
additional messages were not displayed. Instead, the window appeared static,
even while recording continued.

Now, the timeline window incorporates any newly recorded messages, resizing
as needed in order to dynamically update the window.

Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
mjeronimo added a commit that referenced this pull request Oct 20, 2020
@mjeronimo
Dynamically resize the timeline when recording (#66)
95efebc 
Previously, when recording, once the timeline window had filled with messages,
additional messages were not displayed. Instead, the window appeared static,
even while recording continued.

Now, the timeline window incorporates any newly recorded messages, resizing
as needed in order to dynamically update the window.

Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
@mjeronimo mjeronimo deleted the mjeronimo/reset-zoom-when-recording branch October 21, 2020 21:23
@jacobperron jacobperron mentioned this pull request Oct 27, 2020
Merged
mjeronimo added a commit that referenced this pull request Oct 28, 2020
@mjeronimo
Update the rosbag2 python module (#71)
7b07c02 
* Dynamically resize the timeline when recording (#66)

Previously, when recording, once the timeline window had filled with messages,
additional messages were not displayed. Instead, the window appeared static,
even while recording continued.

Now, the timeline window incorporates any newly recorded messages, resizing
as needed in order to dynamically update the window.

Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>

* Update the rosbag2 python module

Fix a few minor issues and add some support functions to:

* Get the sizeof the rosbag
* Get information about a topic (name and type)
* Convert an entry to a ROS message

Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>

* Address review feedback

Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mabelzhang mabelzhang mabelzhang approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjeronimo @dirk-thomas @mabelzhang