-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash during merge sort of bag entries (fixes #90) #93
Conversation
As noted in ros-visualization#90, the previously used function was removed in ros_comm. This makes rqt_bag usable again on ROS Noetic and is compatible with Python 2 distros.
This is very useful. Please merge asap! |
I can confirm this doesn't break Melodic :) |
@mjeronimo or @mabelzhang, can you please take a look? |
Thank you! :-) Could we get a patch-release with this fix please? |
I'd suggest releasing after #94 is merged, too... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thx for the fix! 👍 |
As noted in #90, the previously used function was removed in ros_comm
for Noetic.
This makes rqt_bag usable again on ROS Noetic and is compatible with
Python 2 distros.