ensure data types match what PyQt expects #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
|
Pinging this @ivanpauno, would you be able to review please? #111 explains why these changes are necessary. |
ivanpauno
approved these changes
Aug 22, 2022
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
|
@ijnek I needed one extra change to make rqt_bag work, could you double check it? |
|
@ivanpauno LGTM, thanks for testing it out! |
|
I forgot to run CI ...
|
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/when-will-rqt-bag-be-synced-on-humble/27168/4 |
|
@Mergifyio backport humble |
mergify bot
pushed a commit
that referenced
this pull request
Sep 2, 2022
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com> (cherry picked from commit fd889ae) # Conflicts: # rqt_bag/src/rqt_bag/timeline_frame.py
✅ Backports have been created
|
ivanpauno
added a commit
that referenced
this pull request
Sep 5, 2022
) * ensure data types match what PyQt expects (#118) Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com> (cherry picked from commit fd889ae) # Conflicts: # rqt_bag/src/rqt_bag/timeline_frame.py * Fix conflicts Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> Co-authored-by: Kenji Brameld <kenjibrameld@gmail.com> Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more fixes for #111