-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rqt_bag_plugins missing plot feature from rxbag_plugins #85
Comments
Yes this was not added since there is a complete rqt_plot plugin that has basically the same function. If you load rqt_plot along side rqt_bag and have rqt_bag publish the message to rqt_plot you will get similar functionality to the old rxbag plot plugin. Please reopen this ticket if you have any issues using rqt_plot in this manner. |
I agree that similar functionality is possible using rqt_plot; however, I've found in quite a few situations that it was very convenient, especially for debugging purposes, to be able to view the entire topic plot instantly, without having to set rqt_plot to use simulated time and then either wait for the bag file to play, or run 'rosbag play' with '-i' in the command line. I realize that in some ways having both plugins may seem redundant; however, I think an rqt_bag plot view in addition to the raw and image views would have a great deal of utility. |
Would you be interested in putting that plugin together? You might be able to reuse a bunch of the rqt_plot code actually. |
I'll take a look at it and see what progress I can make. |
Hi, For me, the link with rqt_plot is a complete misuse of rqt_bag. The big advantage of rxbag was that one could plot the value of some variable field over the full length of the bag (i.e. a few hours for me) without having to play/wait. Even more interesting, rxbag was doing multi-resolution, sampling first coarsely the entire timeline and then refining. Personally, I don't see any advantage of rqt_bag/rxbag over rosbag play if the plot feature is not there. I'd say missing the plot feature is a regression since I have to resort to an older version of rxbag to have something that works... Shall I reopen/copy the ticket? |
If you are willing to put in a pull request creating the rqt_bag plugin for plotting I will gladly review it. Otherwise, Unfortunately at the moment there are no developers available to work on features like this. Either way, If you can go into detail with pictures of the benefits of having a plotter plugin inside the bag plugin here I am willing to re-open discussion on this topic. |
Hi Aaron, The simplest demo is simple: take a bag of high frequency topic for a Now, open it with rxbag in fuerte. You can plot the full timeline in one Now switch to groovy. How do you get the same effect? Playing the bag is Now assume that the recording has been done asking rosbag to split the file A solution would be either for rqt_plot to be able to load a set of bags, Another one would be for rqt_bag to offer the option to build a static plot of the content as a plugin.Cedric, mobile, big-thumbed and concise
|
Ok, I'm convinced that this is a good enhancement request. Would you mind copy/pasting this in a new issue with a nice title to that effect and I will mark it as such so it can get addressed when developer time is available? |
Lets just reopen this ticket. The title is specific enough imo and describes the desired feature. |
Ok I'm ok with that. |
Maybe someone is interested, I've made a (kind of dirty) fork for using rxbag with rxbag_plugins for the plotting and image showing here: Its not ideal but it works. (I tried to work a bit on adding this to rqt_bag in some way but I was overwhelmed by the rqt_ stuff :( ). |
I ended up creating a very simple plugin for my own use which relies on matplotlib, but it may be useful to others as well. I'd be interested in getting feedback from anyone wanting to try it out: I haven't written any sort of data limits yet, so it won't work well for very long bag files. All the data points for a given topic are plotted at once. I'm planning on next adding user inputs to limit the times and resolution that the data is plotted at. |
If someone wants to look into this feature I can only highly recommend to reuse the widgets / code already existing in the rqt_plot package. |
I've refactored rqt_plot so that the backend is separate in #232. I'm going to take a look at doing this on the rqt_plot backend, as @dirk-thomas suggests. |
I'm currently working on an rqt_bag plotting plugin based on @adwilson10 's version, using the rqt_plot backend in https://github.com/trainman419/rqt_common_plugins/tree/rqt_bag_plot @adwilson10 I really like the resolution setting and limits in your version. |
The plot plugin of rxbag_plugins does not appear to be ported yet to rqt_bag_plugins. Does this functionality appear elsewhere in rqt, ie. plotting the entire time series of a bag file topic at once?
The text was updated successfully, but these errors were encountered: