Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Added nested subnamespaces and more options to hide or group topics. #13
rqt_graph has had a long-standing problem; in real use cases, graphs quickly become unwieldy and unreadable, with dynamic reconfigure's parameter topics everywhere, and don't even start with images.
This pull request aims to solve these problems with several changes, including:
These changes, originally implemented in #9, have been split into six separate commits, with formatting changes removed, for ease of review.
These changes are dependent on pull request ros-visualization/qt_gui_core#87.
Note that the Hide section of the toolbar has been shifted down to a new line, and margins have been changed as the creation of a new line caused spacing problems.
Three files are attached to this pull request; the launch file I used for testing, a before picture, and an after picture, displaying what rqt_graph looks like before and after the changes.
This was referenced
Aug 2, 2017
@dirk-thomas These changes have gone 22 days since they have been revised and split into separate requests with no response. Overall, they provide significant improvements to the user experience and I would like them to be implemented as soon as possible.
dirk-thomas left a comment •
The new feature looks very nice on more complex graphs
I added some comments inline - mostly nitpicks.
Beside them the toolbar looks a bit off for me:
This repo only has a single
I would rather not create separate branches in this repo for this feature but that would require to backport the