include cv_bridge.hpp instead of cv_bridge.h #80
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
reviewed
Nov 7, 2023
There was a problem hiding this comment.
This is a bit tricky since this same branch is used for Rolling, Iron, and Humble. In Rolling, only cv_bridge.hpp exists. In Iron, both cv_bridge.h and cv_bridge.hpp exist. In Humble, only cv_bridge.h exists.
So I think what we need to do here is to make a branch specifically for Humble, and then apply this to rolling-devel. I'll go ahead and do that.
clalancette
approved these changes
Nov 7, 2023
clalancette
merged commit da64a24
into
ros-visualization:rolling-devel
3 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cv_bridge.h was removed recently ros-perception/vision_opencv@f2fa8b5