Cleanups to the install scripts. #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bring rqt_reconfigure in line with the rest of the rqt tools. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
I just tested it out on Dashing, Foxy, and Galactic, and it seems to work on all of them. It also works on Windows in Galactic. So I'm going to go ahead and run CI and then merge this.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bring rqt_reconfigure in line with the rest of the rqt
tools.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
One caveat here is that I have not tested this on Dashing yet, so we may need a new branch if this doesn't work there.